search

comet-ml / opik

Open-source end-to-end LLM Development Platform
Apache License 2.0
1.36k stars 73 forks source link

[NA] Remove New Relic dependency #254

Open thiagohora opened 1 week ago

thiagohora commented 1 week ago

Details

In order to make it work, we only need to set the disable envvar to false and the the following variables:

      OTEL_EXPORTER_OTLP_ENDPOINT: https://otlp.nr-data.net:4317
      OTEL_EXPORTER_OTLP_HEADERS: "api-key=xxxxxxxxx"

Issues

Screenshot 2024-09-17 at 23 45 11

Resolves #

Testing

The integration was tested locally using a custom API key from our OTEL provider.

Documentation

thiagohora commented 1 week ago

The change looks generally good to me, just a minor recommendation about the configuration.

Please fill up the description template of this PR. I'm missing information, specially about:

  • How was this tested?
  • Any test follow-up actions after deploying?
  • What infrastructure do we need to deploy in order for this to work? Do we require deploying the OTEL agent priorly.
  • Does this work directly with New Relic? Or are there any follow-up actions?
  • What about Prometheus/Grafana?

Hi @andrescrz

1) All the changes were tested locally using a test APIKEY and pointing to our provider, New Relic. 2) Next step is to enable it in Staging and validate the setup 3) The agent is automatically downloaded during the application startup. As we are sending data to New Relic, no infra is needed unless we also want to send it to Grafana. 4) Yes, it works out-of-the-box by pointing to the New Relic backend (More in the PR description) 5) Grafana seems to be instrumented via the Kubernetes cluster so far. As I mentioned, we can also send application data to it, but we are not currently doing it, so I would address this in this PR. Maybe @liyaka can clarify it.