OPIK-72 Add batch remove traces endpoint - Githubissues

comet-ml / opik

Open-source end-to-end LLM Development Platform

Apache License 2.0

1.36k stars 73 forks source link

OPIK-72 Add batch remove traces endpoint #256

Closed andrescrz closed 1 week ago

andrescrz commented 1 week ago

Details

Added endpoint to delete traces by a set of UUIDs. It has the same logic as the existing method for a single UUID, that means:

Feedback scores related to the traces are deleted in cascade.
Spans related to the traces are deleted in cascade.
Feedback scores of the spans related to the traces are deleted in cascade.
Then, the traces are deleted.

Issues

OPIK-72

Testing

Added integration tests covering all the logic explained above for the delete traces endpoint.
Added integration tests covering all the logic explained above for the deleted trace endpoint.
All cases manually tested.
Found and fixed multiple issues in the existing tests.
Refactors and improvements in the related resouce integration test classes.

Documentation

N/A

andrescrz commented 1 week ago

Great job on the tests.

I just remembered that we are missing the deletion of experiment items related to a trace. Otherwise, the feedback score counts and avg will be impacted

Discussed offline and decided to not to cascade deletions to experiment items.