Closed thiagohora closed 1 month ago
nice! what additional parameters do we add for URL ? i think its cleaner to have an additional config and not url changes. but this looks ok for now
&wrapperPlugins=iam
is used to enable the IAM auth, the issue that Dropwizard defines in the DB configuration schema. What we can do is Document how to create a volume to change the config.yml
Hi @andrescrz and @Nimrod007,
The E2E tests are failing because the variable changes are not backward compatible.
Run docker logs opik-backend-1 > /home/runner/work/opik/opik/opik-backend_p3.9.log
java.sql.SQLException: Driver:com.mysql.cj.jdbc.Driver@5aaaa446 returned null for URL:mysql:3306/opik?createDatabaseIfNotExist=true&rewriteBatchedStatements=true
at org.apache.tomcat.jdbc.pool.PooledConnection.connectUsingDriver(PooledConnection.java:365)
at org.apache.tomcat.jdbc.pool.PooledConnection.connect(PooledConnection.java:227)
at org.apache.tomcat.jdbc.pool.ConnectionPool.createConnection(ConnectionPool.java:779)
at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:707)
at org.apache.tomcat.jdbc.pool.ConnectionPool.init(ConnectionPool.java:506)
at org.apache.tomcat.jdbc.pool.ConnectionPool.<init>(ConnectionPool.java:155)
at org.apache.tomcat.jdbc.pool.DataSourceProxy.pCreatePool(DataSourceProxy.java:[11](https://github.com/comet-ml/opik/actions/runs/11010029638/job/30571004042?pr=306#step:8:12)8)
at org.apache.tomcat.jdbc.pool.DataSourceProxy.createPool(DataSourceProxy.java:107)
Hi @andrescrz and @Nimrod007,
The E2E tests are failing because the variable changes are not backward compatible.
Run docker logs opik-backend-1 > /home/runner/work/opik/opik/opik-backend_p3.9.log java.sql.SQLException: Driver:com.mysql.cj.jdbc.Driver@5aaaa446 returned null for URL:mysql:3306/opik?createDatabaseIfNotExist=true&rewriteBatchedStatements=true at org.apache.tomcat.jdbc.pool.PooledConnection.connectUsingDriver(PooledConnection.java:365) at org.apache.tomcat.jdbc.pool.PooledConnection.connect(PooledConnection.java:227) at org.apache.tomcat.jdbc.pool.ConnectionPool.createConnection(ConnectionPool.java:779) at org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:707) at org.apache.tomcat.jdbc.pool.ConnectionPool.init(ConnectionPool.java:506) at org.apache.tomcat.jdbc.pool.ConnectionPool.<init>(ConnectionPool.java:155) at org.apache.tomcat.jdbc.pool.DataSourceProxy.pCreatePool(DataSourceProxy.java:[11](https://github.com/comet-ml/opik/actions/runs/11010029638/job/30571004042?pr=306#step:8:12)8) at org.apache.tomcat.jdbc.pool.DataSourceProxy.createPool(DataSourceProxy.java:107)
Thanks for letting us know. This would've passed if the end 2 end tests Github action was using an image containing the changes in the PR instead of the latest main version.
Added disbaled test to help/test setup
Details
Issues
OPIK-135
Testing
Locally, assuming a ROLE with the required access to RDS.
Documentation
In order to enable the Authentication using the AWS IAM mechanism, the user needs the following:
AWSAuthenticationPlugin
as authentication mode for the target MySQL user. See link.software.amazon.jdbc.Driver
instead ofcom.mysql.cj.jdbc.Driver
STATE_DB_PROTOCOL
to update the connection string. Usejdbc:aws-wrapper:mysql://
instead ofjdbc:mysql://
STATE_DB_PLUGINS
toiam
or other valid plugins. For more valid options, see linkSTATE_DB_PASS
to empty.