Closed madsted closed 7 months ago
@JamieMcMillan
Agreed, better unittest coverage for comet_maths & this module in particular would definitely be beneficial. I think that's out of the remit of this pull request however, as that will involve adding tests for more of the module, not just for the small change made in this request.
Feel free to ignore if you would like :)
It would be good to include testing for the changes you are adding. From the pytest coverage report, this file is hitting about 63 % statement coverage.
Here you could add a
def test_pchip_interpolation()
that largely follows the test structure already in place. And a verification of theNotImplementedError
usingwith pytest.raises(NotImplementedError):
(def test_pchip_interpolation_multi_dimension_warning
).