search

comet-toolkit / obsarray

Measurement uncertainty handling in Python
GNU Lesser General Public License v3.0
7 stars 1 forks source link

Amended documentation example code #13

Closed JamieMcMillan closed 9 months ago

JamieMcMillan commented 1 year ago

Example defined flag_meanings but without an attribute parent property. The parent property has been added.

If this is not added line 134 from ./obsarray/templater/template_util.py attempts to .pop a None object.

JamieMcMillan commented 1 year ago

Had a day playing with the repo and noted what looked to me to be an error in the docs.

Feel free to merge if you would like :)

JamieMcMillan commented 1 year ago

How are you getting on with this review @shunt16 ?

shunt16 commented 9 months ago

Hi Jamie - sorry I didn't get round to this one for so long. It was mainly because I was planning a big update to the docs which I have only finished now. So will close this