cometbft / cometbft-db

Database wrapper for CometBFT
Apache License 2.0
29 stars 51 forks source link

chore(pebbledb): remove isForceSync flag #125

Closed melekes closed 9 months ago

melekes commented 9 months ago

Downstream dependencies should use SetSync/DeleteSync to force flushing OS buffers to disk.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5424fbb) 76.91% compared to head (24c10fc) 76.74%.

:exclamation: Current head 24c10fc differs from pull request most recent head 1ee4498. Consider uploading reports for the commit 1ee4498 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125/graphs/tree.svg?width=650&height=150&src=pr&token=QcxCp5s2sq&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft)](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) ```diff @@ Coverage Diff @@ ## main #125 +/- ## ========================================== - Coverage 76.91% 76.74% -0.17% ========================================== Files 23 23 Lines 2058 2043 -15 ========================================== - Hits 1583 1568 -15 Misses 403 403 Partials 72 72 ``` | [Files](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) | Coverage Δ | | |---|---|---| | [boltdb.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Ym9sdGRiLmdv) | `57.25% <ø> (ø)` | | | [cleveldb\_iterator.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Y2xldmVsZGJfaXRlcmF0b3IuZ28=) | `88.31% <100.00%> (-0.15%)` | :arrow_down: | | [pebble.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cGViYmxlLmdv) | `73.04% <ø> (-1.31%)` | :arrow_down: | | [rocksdb\_iterator.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cm9ja3NkYl9pdGVyYXRvci5nbw==) | `92.94% <100.00%> (-0.09%)` | :arrow_down: | | [badger\_db.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-YmFkZ2VyX2RiLmdv) | `87.77% <0.00%> (ø)` | | | [Files](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) | Coverage Δ | | |---|---|---| | [boltdb.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Ym9sdGRiLmdv) | `57.25% <ø> (ø)` | | | [cleveldb\_iterator.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Y2xldmVsZGJfaXRlcmF0b3IuZ28=) | `88.31% <100.00%> (-0.15%)` | :arrow_down: | | [pebble.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cGViYmxlLmdv) | `73.04% <ø> (-1.31%)` | :arrow_down: | | [rocksdb\_iterator.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cm9ja3NkYl9pdGVyYXRvci5nbw==) | `92.94% <100.00%> (-0.09%)` | :arrow_down: | | [badger\_db.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-YmFkZ2VyX2RiLmdv) | `87.77% <0.00%> (ø)` | |