cometbft / cometbft-db

Database wrapper for CometBFT
Apache License 2.0
29 stars 51 forks source link

feat: enhance pebble #141

Closed faddat closed 7 months ago

faddat commented 7 months ago
codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 54.05405% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 74.94%. Comparing base (fb4f703) to head (d597789). Report is 11 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141/graphs/tree.svg?width=650&height=150&src=pr&token=QcxCp5s2sq&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft)](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) ```diff @@ Coverage Diff @@ ## main #141 +/- ## ========================================== - Coverage 76.80% 74.94% -1.87% ========================================== Files 23 13 -10 Lines 2048 930 -1118 ========================================== - Hits 1573 697 -876 + Misses 403 190 -213 + Partials 72 43 -29 ``` | [Files](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) | Coverage Δ | | |---|---|---| | [goleveldb.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?src=pr&el=tree&filepath=goleveldb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Z29sZXZlbGRiLmdv) | `65.51% <100.00%> (+5.67%)` | :arrow_up: | | [pebble.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?src=pr&el=tree&filepath=pebble.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cGViYmxlLmdv) | `70.71% <37.03%> (-2.86%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) | [Files](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft) | Coverage Δ | | |---|---|---| | [goleveldb.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?src=pr&el=tree&filepath=goleveldb.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-Z29sZXZlbGRiLmdv) | `65.51% <100.00%> (+5.67%)` | :arrow_up: | | [pebble.go](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141?src=pr&el=tree&filepath=pebble.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft#diff-cGViYmxlLmdv) | `70.71% <37.03%> (-2.86%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/cometbft/cometbft-db/pull/141/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cometbft)
github-actions[bot] commented 7 months ago

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

melekes commented 7 months ago

I'm sorry @faddat. This PR is too big and needs to be broken down into smaller parts.