search

cometbft / cometbft-db

Database wrapper for CometBFT
Apache License 2.0
29 stars 51 forks source link

Bump minimum Go version to v1.20 #65

Closed thanethomson closed 1 year ago

thanethomson commented 1 year ago

Since we currently don't plan on using cometbft-db v0.8.0 in CometBFT v0.34.x, it seems safe to bump the minimum supported Go version for the cometbft-db v0.8.x series to Go v1.20.

Also, with regard to https://github.com/cometbft/cometbft/pull/777#issuecomment-1593743103, doing so will allow us to build a cometbft-db-testing image based on Go v1.20 that we can use as a base for our CometBFT E2E test image that pre-packages manually built cleveldb and RocksDB support.

This way our E2E test image will be able to use whatever the current supported underlying versions of cleveldb and RocksDB have been tested with cometbft-db.

I've also updated the linting settings to use the latest version of golangci-lint locally and in CI, and have added the relevant depguard rules to get the linter to pass.

lasarojc commented 1 year ago

The error seems to be caused by using gcc 12. Trying with 11

thanethomson commented 1 year ago

Nice, thanks @lasarojc!