cometchat / cometchat-uikit-react-native

Ready-to-use Chat UI Components for React Native
https://www.cometchat.com
Other
40 stars 24 forks source link

Long-press Bottom Sheet Menu Issues #51

Closed lance-zigazoo closed 1 year ago

lance-zigazoo commented 1 year ago

Describe the problem

Long-press menu does not work consistently: When interacting with the long-press menu on a message bubble, image, video, etc. a bottom sheet is presented to the user on the screen. Many times, the bottom sheet's rendered items do not appear, e.g. the "Delete", "Start a thread" and other messages. Additionally after several attempts (depends on device) a noticeable performance degradation takes place, e.g. the menu animation begins to slow substantially, and interacting with the chat components leaves much to be desired in the way of performance.

What was the expected behavior?

I expect the experience to be consistent (menu content renders every time), and I expect that the performance of the application is not affected by using the long-press / bottom sheet menu functionality.

Reproduction

Detail the steps taken to reproduce this error, and whether this issue can be reproduced consistently or if it is intermittent. Note: If clear, reproducable steps or the smallest sample app demonstrating misbehavior cannot be provided, we may not be able to follow up on this bug report.

(android emulator an iOS devices seem to suffer the problem the most)

  1. Open a chat
  2. Send a message
  3. Long press on the message bubble to summon the action menu
  4. Dismiss action menu
  5. Repeat several times

Android Example (kitchen sink app cloned from CCPro repo) iOS Example (using rn toolkit in our app)

The code flow appears to be: Long press chat bubble in CometChatSenderImageMessageBubble -> CometChatMessage -> Close -> CometChatMessageActions -> CometChatMessageActions/actions

Where applicable, please include:

  • The smallest possible sample app that reproduces the undesirable behavior
  • Log files (redact/remove sensitive information)
  • Application settings (redact/remove sensitive information)
  • Screenshots

For the above points, your Kitchen Sink app exhibits the behavior as-is.

Environment

Please provide the following:

proveshapyne commented 1 year ago

Hey @lance-zigazoo,

Thanks for sharing these details. We're investigating and will reach out with an update shortly.

Provesha Pyne CometChat

cometchat-helpcenter-bot commented 1 year ago

Provesha (CometChat Team) replied:

Hello Lance,

I've requested access to the Android Example (kitchen sink app cloned from CCPro repo) shared in the GitHub ticket. Can you please provide me access to this?

Provesha Pyne CometChat

lance-zigazoo commented 1 year ago

Hi Provesha, it is a Comet Chat repo, you should have access to it.

On Wed, Mar 1, 2023 at 7:43 AM CometChat Help Center Bot < @.***> wrote:

Provesha (CometChat Team) replied:

Hello Lance,

I've requested access to the Android Example (kitchen sink app cloned from CCPro repo) shared in the GitHub ticket. Can you please provide me access to this?

Provesha Pyne CometChat

— Reply to this email directly, view it on GitHub https://github.com/cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51#issuecomment-1450088646, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4T5H734VNYMQQFLAGMOSHDWZ4763ANCNFSM6AAAAAAVKCLZJU . You are receiving this because you were mentioned.Message ID: <cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51/1450088646@ github.com>

lance-zigazoo commented 1 year ago

I may have cloned it, in which case, you should be able to just use the root project.

On Wed, Mar 1, 2023 at 8:35 AM Lance Sims @.***> wrote:

Hi Provesha, it is a Comet Chat repo, you should have access to it.

On Wed, Mar 1, 2023 at 7:43 AM CometChat Help Center Bot < @.***> wrote:

Provesha (CometChat Team) replied:

Hello Lance,

I've requested access to the Android Example (kitchen sink app cloned from CCPro repo) shared in the GitHub ticket. Can you please provide me access to this?

Provesha Pyne CometChat

— Reply to this email directly, view it on GitHub https://github.com/cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51#issuecomment-1450088646, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4T5H734VNYMQQFLAGMOSHDWZ4763ANCNFSM6AAAAAAVKCLZJU . You are receiving this because you were mentioned.Message ID: <cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51/1450088646@ github.com>

cometchat-helpcenter-bot commented 1 year ago

Provesha (CometChat Team) replied:

Hey Lance,

The team informs me that they tried to reproduce the issue on Android as you mentioned on the call but did not see any performance degradation on Android Emulator (Pixel 6 API version 32). We also tested this on a physical device (OnePlus 7), and everything works as expected. Can you share the Android emulator you use?

We could reproduce the issue on iOS devices although it was not as frequent as was demonstrated on the call.

Provesha Pyne CometChat

lance-zigazoo commented 1 year ago

Hi Provesha,

Thank you for the message.

Please find the AVD here https://drive.google.com/file/d/1vYcPIHma2ZuXOd6KDQEkKYq_7KWDDPRm/view?usp=share_link .

At this point, our team believes that we have provided enough materials and anecdotal evidence to assist in the debugging process, however results have not been delivered yet. We have a critical application release coming up that includes the use of Comet Chat, and our deadlines are not flexible. I would like to request that you assign an engineer to work with me in real-time to come bring this issue to a speedy resolution.

Please let me know what we can arrange at your earliest convenience.

Regards,

Lance

On Thu, Mar 2, 2023 at 1:05 AM CometChat Help Center Bot < @.***> wrote:

Provesha (CometChat Team) replied:

Hey Lance,

The team informs me that they tried to reproduce the issue on Android as you mentioned on the call but did not see any performance degradation on Android Emulator (Pixel 6 API version 32). We also tested this on a physical device (OnePlus 7), and everything works as expected. Can you share the Android emulator you use?

We could reproduce the issue on iOS devices although it was not as frequent as was demonstrated on the call.

Provesha Pyne CometChat

— Reply to this email directly, view it on GitHub https://github.com/cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51#issuecomment-1451347455, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4T5H75H5HQQB22HMSTUEM3W2A2D5ANCNFSM6AAAAAAVKCLZJU . You are receiving this because you were mentioned.Message ID: <cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51/1451347455@ github.com>

cometchat-helpcenter-bot commented 1 year ago

Keagan Ellis (CometChat Team) replied:

Hello Lance,

The request has been raised to the engineering team to fix the iOS issue. We will notify you once we have more information about the fix.

Keagan Ellis CometChat

cometchat-helpcenter-bot commented 1 year ago

Juhi (CometChat Team) replied:

Thank you! We have sent this request to our product engineering team. We will inform you once this bug has been resolved.

Juhi Saha Associate Principal Software Devloper CometChat

lance-zigazoo commented 1 year ago

Thank you Keagan and Juhi,

A minor point of clarification is that this is not isolated to iOS, however it it more easily reproduced on that platform, at least in our case. There is a call to onCloseEnd that seems to be triggered unexpectedly at times.

Regards,

Lance

On Thu, Mar 9, 2023 at 12:59 AM CometChat Help Center Bot < @.***> wrote:

Juhi (CometChat Team) replied:

Thank you! We have sent this request to our product engineering team. We will inform you once this bug has been resolved.

Juhi Saha Associate Principal Software Devloper CometChat

— Reply to this email directly, view it on GitHub https://github.com/cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51#issuecomment-1461333355, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4T5H7ZPMEZ6JC67FLLNFPTW3FWVBANCNFSM6AAAAAAVKCLZJU . You are receiving this because you were mentioned.Message ID: <cometchat-pro/cometchat-pro-react-native-ui-kit/issues/51/1461333355@ github.com>

cometchat-helpcenter-bot commented 1 year ago

Juhi (CometChat Team) replied:

Hello Lance,

Regarding your request, would like to keep you posted that our product engineering team is discussing a resolution and will get back soon with an update.

Have a great weekend!

Juhi Saha Associate Principal Software Developer CometChat

cometchat-helpcenter-bot commented 1 year ago

Vivek (CometChat Team) replied:

Hello, Please check the new release here and confirm if the issue has been fixed?

Thanks,

Vivek Prajapati CometChat

jasimawan commented 2 months ago

How can I disable the long press bottom sheet?