Closed tony closed 3 years ago
Hey @tony, Thank you for the reporting
Could you try: https://github.com/dotansimha/graphql-code-generator/releases/tag/%40graphql-codegen%2Fvisitor-plugin-common%401.18.2
You can pin this with yarn's resolutions
fields in the package.json
{
"resolutions": {
"@graphql-codegen/visitor-plugin-common": "1.18.2"
}
}
and yarn install
The error still happens with the resolutions set
I use a monorepo so making an example is complex.
I won't be able to go into depth / show project config until tomorrow
It seems the visitor-plugin-common in your lock file is still 1.18.1
, not 1.18.2
(just published)
yarn why @graphql-codegen/visitor-plugin-common
command may help you
or... just delete yarn.lock
and install again?
yarn why v1.22.10
[1/4] Why do we have the module "@graphql-codegen/visitor-plugin-common"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "@graphql-codegen/visitor-plugin-common@1.18.2"
info Reasons this module exists
- "_project_#@graphql-codegen#flow" depends on it
- Hoisted from "_project_#@graphql-codegen#flow#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@graphql-codegen#typescript#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#flow-resolvers#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#typescript-resolvers#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#flow-operations#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#typescript-operations#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#typescript-resolvers#@graphql-codegen#typescript#@graphql-codegen#visitor-plugin-common"
- Hoisted from "_project_#@project#custom-typings#gatsby-plugin-typegen#@graphql-codegen#flow-operations#@graphql-codegen#flow#@graphql-codegen#visitor-plugin-common"
info Disk size without dependencies: "964KB"
info Disk size with unique dependencies: "8.66MB"
info Disk size with transitive dependencies: "65.43MB"
info Number of shared dependencies: 149
Done in 1.74s.
With new yarn.lock
Strange. Are you seeing exactly the same stack trace?
I had the same problem in my environment. (GitHub Actions Node 14).
https://github.com/tubone24/portfolio/runs/1770687555?check_suite_focus=true
New stacktrace
ERROR
[object Object] str.replace is not a function
TypeError: str.replace is not a function
- enum-values.js:5 escapeString
dist/plugins/other/visitor-plugin-common/src/enum-values.js:5:16
- enum-values.js:18 parseEnumValues
dist/plugins/other/visitor-plugin-common/src/enu
m-values.js:18:68
- base-types-visitor.js:15 new BaseTypesVisitor
dist/plugins/other/visitor-plugin-common/src/bas
e-types-visitor.js:15:25
- visitor.js:10 new TsVisitor
dist/plugins/typescript/typescript/src/visitor.j
s:10:9
- index.js:9 Object.plugin
dist/plugins/typescript/typescript/src/index.js:
9:21
- execute-plugin.js:31 executePlugin
dist/graphql-codegen-core/src/execute-plugin.js:
31:35
- codegen.js:77
dist/graphql-codegen-core/src/codegen.js:77:30
- Array.map
- codegen.js:67 codegen
dist/graphql-codegen-core/src/codegen.js:67:54
- codegen.js:129
[project]/[gatsby-plugin-typegen]/workers/codegen.js:129:20
Ah, I think you still have deps resolution problem.
It seems you are using npm install
instead of yarn install
, which does not guarantee the version you pinned.
Can you change it to yarn install --frozen-lockfile
and check again?
and the @tony's new stacktrace... I'm going to report it upstream again.
2.2.4 still gives this for me
Edit: I spoke too soon, this gives me the error still
Yeah, I've submitted PR to fix and waiting.
@tony We can try to manually apply this patch: https://github.com/dotansimha/graphql-code-generator/pull/5457
At the moment my current workaround avoiding upgrading + this in package.json
:
{
"resolutions": {
"@graphql-codegen/visitor-plugin-common": "1.17.22"
}
}
I had fixed the type error on graphql-codegen, and it seems to resolve this issue
@tony let me know if you still have a problem
Will do, thank you!
"gatsby-plugin-typegen": "^2.2.2"
->"gatsby-plugin-typegen": "^2.2.3",
yarn.lock