comfy / comfortable-mexican-sofa

ComfortableMexicanSofa is a powerful Ruby on Rails 5.2+ CMS (Content Management System) Engine
MIT License
2.72k stars 638 forks source link

Codemirror in tabs #273

Closed hazg closed 11 years ago

hazg commented 11 years ago

Codemirror does't activated after clicking on non primary tab.

codemirror-bug

Manual calling $.CMS.enable_codemirror(); or changing text fix it.

GBH commented 11 years ago

Can you confirm this? Works for me here. When you start typing you'll see the line numbers in the gutter.

hazg commented 11 years ago

When i start typing, line numbers and text becomes visible. i can select invisible text, like in screenshot. it's happend only in non primary tabs with filled textbox.

to reproduce:

  1. add 2 tab's
  2. add some text part in the second tab
  3. fill it with some html
  4. reload page
  5. switch to second tab

Ubuntu: chrome, opera, ff ... no errors in console

GIT
  remote: git://github.com/comfy/comfortable-mexican-sofa
  revision: d6d8c0c9518f34445aa546b4b8ec253ca5939aa5
  specs:
    comfortable_mexican_sofa (1.7.1)
      active_link_to (>= 1.0.0)
      coffee-rails (>= 3.1.0)
      formatted_form (>= 2.1.0)
      haml-rails (>= 0.3.0)
      jquery-rails (>= 2.2.0)
      paperclip (>= 3.4.0)
      rails (>= 3.1.0)
      redcarpet (>= 2.2.0)
      sass-rails (>= 3.1.0)

GEM
  remote: https://rubygems.org/
  specs:
    actionmailer (3.2.12)
      actionpack (= 3.2.12)
      mail (~> 2.4.4)
    actionpack (3.2.12)
      activemodel (= 3.2.12)
      activesupport (= 3.2.12)
      builder (~> 3.0.0)
      erubis (~> 2.7.0)
      journey (~> 1.0.4)
      rack (~> 1.4.5)
      rack-cache (~> 1.2)
      rack-test (~> 0.6.1)
      sprockets (~> 2.2.1)
    active_link_to (1.0.0)
    activemodel (3.2.12)
      activesupport (= 3.2.12)
      builder (~> 3.0.0)
    activerecord (3.2.12)
      activemodel (= 3.2.12)
      activesupport (= 3.2.12)
      arel (~> 3.0.2)
      tzinfo (~> 0.3.29)
    activeresource (3.2.12)
      activemodel (= 3.2.12)
      activesupport (= 3.2.12)
    activesupport (3.2.12)
      i18n (~> 0.6)
      multi_json (~> 1.0)
    arel (3.0.2)
    better_errors (0.7.0)
      coderay (>= 1.0.0)
      erubis (>= 2.6.6)
    binding_of_caller (0.7.1)
      debug_inspector (>= 0.0.1)
    builder (3.0.4)
    chunky_png (1.2.7)
    climate_control (0.0.3)
      activesupport (>= 3.0)
    cocaine (0.5.1)
      climate_control (>= 0.0.3, < 1.0)
    coderay (1.0.9)
    coffee-rails (3.2.2)
      coffee-script (>= 2.2.0)
      railties (~> 3.2.0)
    coffee-script (2.2.0)
      coffee-script-source
      execjs
    coffee-script-source (1.6.1)
    columnize (0.3.6)
    compass (0.12.2)
      chunky_png (~> 1.2)
      fssm (>= 0.2.7)
      sass (~> 3.1)
    compass-rails (1.0.3)
      compass (>= 0.12.2, < 0.14)
    debug_inspector (0.0.2)
    debugger (1.2.4)
      columnize (>= 0.3.1)
      debugger-linecache (~> 1.1.1)
      debugger-ruby_core_source (~> 1.1.7)
    debugger-linecache (1.1.2)
      debugger-ruby_core_source (>= 1.1.1)
    debugger-ruby_core_source (1.1.9)
    erubis (2.7.0)
    execjs (1.4.0)
      multi_json (~> 1.0)
    formatted_form (2.1.1)
      rails (>= 3.1.0)
    fssm (0.2.10)
    haml (4.0.0)
      tilt
    haml-rails (0.4)
      actionpack (>= 3.1, < 4.1)
      activesupport (>= 3.1, < 4.1)
      haml (>= 3.1, < 4.1)
      railties (>= 3.1, < 4.1)
    hike (1.2.1)
    i18n (0.6.4)
    journey (1.0.4)
    jquery-rails (2.2.1)
      railties (>= 3.0, < 5.0)
      thor (>= 0.14, < 2.0)
    json (1.7.7)
    kaminari (0.14.1)
      actionpack (>= 3.0.0)
      activesupport (>= 3.0.0)
    libv8 (3.11.8.13)
    mail (2.4.4)
      i18n (>= 0.4.0)
      mime-types (~> 1.16)
      treetop (~> 1.4.8)
    method_source (0.8.1)
    mime-types (1.21)
    multi_json (1.6.1)
    mysql2 (0.3.11)
    paperclip (3.4.1)
      activemodel (>= 3.0.0)
      activerecord (>= 3.0.0)
      activesupport (>= 3.0.0)
      cocaine (~> 0.5.0)
      mime-types
    polyglot (0.3.3)
    pry (0.9.12)
      coderay (~> 1.0.5)
      method_source (~> 0.8)
      slop (~> 3.4)
    pry-debugger (0.2.1)
      debugger (~> 1.2.0)
      pry (~> 0.9.10)
    pry-rails (0.2.2)
      pry (>= 0.9.10)
    pry-stack_explorer (0.4.9)
      binding_of_caller (>= 0.7)
      pry (~> 0.9.11)
    rack (1.4.5)
    rack-cache (1.2)
      rack (>= 0.4)
    rack-ssl (1.3.3)
      rack
    rack-test (0.6.2)
      rack (>= 1.0)
    rails (3.2.12)
      actionmailer (= 3.2.12)
      actionpack (= 3.2.12)
      activerecord (= 3.2.12)
      activeresource (= 3.2.12)
      activesupport (= 3.2.12)
      bundler (~> 1.0)
      railties (= 3.2.12)
    railties (3.2.12)
      actionpack (= 3.2.12)
      activesupport (= 3.2.12)
      rack-ssl (~> 1.3.2)
      rake (>= 0.8.7)
      rdoc (~> 3.4)
      thor (>= 0.14.6, < 2.0)
    rake (10.0.3)
    rdoc (3.12.2)
      json (~> 1.4)
    redcarpet (2.2.2)
    ref (1.0.2)
    russian (0.6.0)
      i18n (>= 0.5.0)
    sass (3.2.6)
    sass-rails (3.2.6)
      railties (~> 3.2.0)
      sass (>= 3.1.10)
      tilt (~> 1.3)
    slop (3.4.3)
    sprockets (2.2.2)
      hike (~> 1.2)
      multi_json (~> 1.0)
      rack (~> 1.0)
      tilt (~> 1.1, != 1.3.0)
    therubyracer (0.11.4)
      libv8 (~> 3.11.8.12)
      ref
    thor (0.17.0)
    tilt (1.3.4)
    treetop (1.4.12)
      polyglot
      polyglot (>= 0.3.1)
    tzinfo (0.3.36)
    uglifier (1.3.0)
      execjs (>= 0.3.0)
      multi_json (~> 1.0, >= 1.0.2)

PLATFORMS
  ruby

DEPENDENCIES
  better_errors
  binding_of_caller
  coffee-rails (~> 3.2.1)
  comfortable_mexican_sofa (~> 1.7.1)!
  compass-rails
  haml-rails
  jquery-rails
  kaminari
  mysql2
  pry-debugger
  pry-rails
  pry-stack_explorer
  rails (= 3.2.12)
  russian
  sass-rails (~> 3.2.3)
  therubyracer
  uglifier (>= 1.0.3)
GBH commented 11 years ago

Yeap, I can reproduce it. Seems to re-enable itself once you start typing though. I'll upgrade to the newest version and see if it fixes itself.

GBH commented 11 years ago

Updating to latest version did nothing. I opened issue at codemirror: https://github.com/marijnh/CodeMirror/issues/1395

GBH commented 11 years ago

Fixed in master branch. Will release with 1.8 this week.

hazg commented 11 years ago

Thanks!