comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
56.32k stars 5.97k forks source link

[Feature Request] Reroute node widget with on/off switch and reroute node widget with patch selector #1051

Open fabiobtex opened 1 year ago

fabiobtex commented 1 year ago

Reroute node widget with on/off switch and reroute node widget with patch selector

-A reroute node (usually for image) that allows to turn off or on that part of workflow just moving a widget like switch button, exemple: Turn on off if the image should go to face restore or not using switch widget.

-A reroute node (usually for image) that allows you to choose the path of workflow the image should go, exemple: Two completely different upscale processes, you use the switch to choose between PATH A and PATH B using the widget switch

n00mkrad commented 1 year ago

Yes, we badly need some sort of if/else conditions.

RIght now it's very tedious to switch between paths (e.g. upscaling on/off, highres fix on/off).

Nikerino commented 1 year ago

As a temporary solution (that won't apply to all cases) - I use https://github.com/LucianoCirino/efficiency-nodes-comfyui This custom node suite has samplers that let you specify whether they should "Sample" or "Hold" - meaning they won't sample and will just pass on to the next part of the workflow. You can achieve a toggleable HiRez workflow this way as well.

fabiobtex commented 1 year ago

As a temporary solution (that won't apply to all cases) - I use https://github.com/LucianoCirino/efficiency-nodes-comfyui This custom node suite has samplers that let you specify whether they should "Sample" or "Hold" - meaning they won't sample and will just pass on to the next part of the workflow. You can achieve a toggleable HiRez workflow this way as well.

Ty for the suggestion

fabiobtex commented 1 year ago

Yes, we badly need some sort of if/else conditions.

RIght now it's very tedious to switch between paths (e.g. upscaling on/off, highres fix on/off).

Yes. I want to make complex full of options workflow more user friendly. I don't mind to turn "never" some key nodes and connect and disconnect noodles manually buy i can't share my workflow unless is for someone that is really experienced.

Aren't you the NMKD guy? I started SD with NMKD gui in November. Very nice, easy to use. Ty for you work

n00mkrad commented 1 year ago

Yes, we badly need some sort of if/else conditions. RIght now it's very tedious to switch between paths (e.g. upscaling on/off, highres fix on/off).

Yes. I want to make complex full of options workflow more user friendly. I don't mind to turn "never" some key nodes and connect and disconnect noodles manually buy i can't share my workflow unless is for someone that is really experienced.

Aren't you the NMKD guy? I started SD with NMKD gui in November. Very nice, easy to use. Ty for you work

Yeah, the reason I'm here is because I'm switching to Comfy as backend for my GUI. The GUI won't change, but Comfy is just way nicer to develop workflows with, compared to Diffusers or Invoke.