comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
48.48k stars 5.1k forks source link

Photoshop plugin #1190

Open Henryokazaki opened 1 year ago

Henryokazaki commented 1 year ago

How big of a project would it be to make the sd auto ps plugin compatible with comfy? (I asked the plugin dev but he's not very responsive). Would appreciate any insight, thank you!

kubilaykilinc commented 1 year ago

+1

Ariffffff commented 1 year ago

there is PS plugin with automatic1111 though, if you wish to try out.

https://github.com/AbdullahAlfaraj/Auto-Photoshop-StableDiffusion-Plugin

lord-lethris commented 1 year ago

Why would you want to run a Memory Resource extensive Program like Photoshop, at the same time as a Memory Resource extensive Program like any AI image application? You're just going to hit resource issues, its inefficient.

Genuine question...

Henryokazaki commented 1 year ago

Why would you want to run a Memory Resource extensive Program like Photoshop, at the same time as a Memory Resource extensive Program like any AI image application? You're just going to hit resource issues, its inefficient.

Genuine question...

I don't have any resource issues, and if I did I would just run Photoshop on my cpu or another gpu. I use them at the same time because it's much more efficient and a lot more fun. If you aren't interested in editing while you inpaint or you have a slow computer then sure, it's probably not for you.

EriIaz commented 11 months ago

Why would you want to run a Memory Resource extensive Program like Photoshop, at the same time as a Memory Resource extensive Program like any AI image application? You're just going to hit resource issues, its inefficient.

Genuine question...

Because Stable Diffusion is the best image generation AI capable of running locally, while Photoshop is the industry standard conventional image editing tool?

Some workflows can benefit from Comfy quite a lot, and if you ask me, it is the opposite of being inefficient. It's only demanding in terms of RAM volume, but that's it.

Consider the inefficiency of turning a traditional image editor or the AI backend on and off manually every single time when you are working on something that requires both tools. I bet my RAM is much faster than my fingers, and it always will be, that's the limitation of my flesh, not a mere skill issue. RAM volume isn't infinite of course, but the same is true for Stable Diffusion and Photoshop memory requirements too. It's not like you need 256GB at minimum, you will be able to use it with just 32GB on a single machine and SD1.5, maaaaybe you'll need 64GB for SDXL with a big PS document, but should be possible to get away with 32, with some RAM utilization discipline.

Also, when you work with Photoshop, it doesn't do massive computations all the time, and when you do, most of them are done on CPU. Even if you use some heavy plugins, they do their job and then wait for human input. But for the most part, it idles. And contrary to the popular belief, Photoshop isn't really that heavy. It's entirely possible to make PS and Comfy coexist, they just have to do their major computations consecutively. Finally, for people who have to rely on simultaneous operation for some reason, it's also entirely possible to split the load on two machines: run PS on one computer, and SD backend on another. An overkill, if you ask me, but it's a solution nonetheless.

Believe it or not, there are people who do a lot of Photoshop job for a living, and they can benefit from a self-hosted image generation tool. So much so losing speed for hopping between applications, let alone turning them on and off all the time, can actually cost them a massive inconvenience at best, and a measurable sum of money at worst, If they can speed up their workflow with some extra RAM, they do. Most of them have 32 or 64GB already anyway. And even if not, the price of RAM upgrade competes with Firefly subscription very well, it makes sense - especially when you actually own your RAM.