Open MagicHatJo opened 11 months ago
Currently, z-index of increments linearly, which places it over other boxes and eventually, even the menu.</p> <p>Examples: <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/be0caa13-706b-4e04-bf85-84c07b8e8d2e" alt="chrome_BxMTQCsQx2" /> <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/49b688de-3c46-4afa-8537-5a399a85cf84" alt="chrome_o0n9swzttq" /> <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/4233dd12-171a-4d60-b92b-cdf18b6ce1d3" alt="chrome_C874GtlsRS" /> <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/a23a3c19-1bd2-4541-80de-28169c0fb2f3" alt="chrome_JVEW5OJXqC" /> <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/e84eb4c2-d049-459a-b5a4-b06b8055576b" alt="chrome_vjgCFImDQb" /></p> <h3>Expected:</h3> <p>Properties, pop ups, and menu should be above node and node contents. <img referrerpolicy="no-referrer" src="https://github.com/comfyanonymous/ComfyUI/assets/38716012/3517dc46-b1a3-45fe-b6aa-c2669019989e" alt="chrome_dWrvmagEMT" /></p> <hr /> <p>For now, I've set custom user css locally to specifically move menu and properties window to 999 and 1000, but this doesn't seem like a good modular solution. Is there a reason for z-index to continually increment, or is this a bug? I can work on this issue if I get a conclusive answer, I'm just not sure if I'm overlooking something that necessitates said incrementations.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/wallish77"><img src="https://avatars.githubusercontent.com/u/39662183?v=4" />wallish77</a> commented <strong> 11 months ago</strong> </div> <div class="markdown-body"> <p>Can confirm that I have seen this issue. Often happens when attempting to rename a node (node rename box ends up behind the node)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/szwang-seedtech"><img src="https://avatars.githubusercontent.com/u/43228022?v=4" />szwang-seedtech</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <p>Is there any solution? I believe it only happens on the text widget</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/ltdrdata"><img src="https://avatars.githubusercontent.com/u/128333288?v=4" />ltdrdata</a> commented <strong> 10 months ago</strong> </div> <div class="markdown-body"> <blockquote> <p>Is there any solution? I believe it only happens on the text widget</p> </blockquote> <p>There is no solution yet. This is a problem that many developers are aware of, already. However, it's an issue that they find difficult to tackle readily because it requires modifications at a very foundational level of the code.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dchatel"><img src="https://avatars.githubusercontent.com/u/1372055?v=4" />dchatel</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <p>The culprit may be related to line 267 of file web/scripts/domWidgets.js:</p> <pre><code class="language-javascript">zIndex: app.graph._nodes.indexOf(node),</code></pre> <p>when I commented this line, it kinda helped a little bit, but this is not the only problem. Another issue I've found is that when you collapse a node which contains a textarea, its css property display very quickly gets to "none" then null, instead of staying to "none". I haven't found where exactly that happens in the code, but if you insist with the browser dev tools, you can see the behavior.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/dchatel"><img src="https://avatars.githubusercontent.com/u/1372055?v=4" />dchatel</a> commented <strong> 2 weeks ago</strong> </div> <div class="markdown-body"> <p>Recently, this bug has gotten worse. <a href="https://github.com/comfyanonymous/ComfyUI/assets/1372055/0c9a2c2a-6f9e-412d-9b90-cfcb724e4222">https://github.com/comfyanonymous/ComfyUI/assets/1372055/0c9a2c2a-6f9e-412d-9b90-cfcb724e4222</a></p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
Problem:
Currently, z-index of