comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
56.32k stars 5.97k forks source link

Fixed search field with a scrollable list when opening a very long one #1545

Open Mikerhinos opened 1 year ago

Mikerhinos commented 1 year ago

I have some custom nodes that have very long lists of available values like styles for example. When the list is pretty big, we can't see the search field as it seems to open from the bottom, and there's no scroll cursor to get to the top of the list quickly :/

image

So if the list was opening at the top by default to have search field viewable, or if the seach field was fixed and independant with a scrollable list above it with a cursor it would be way easier to find the value we want.

Mikerhinos commented 1 year ago

Like if the list was popping like this, with the "Filter list" field pinned at this position, and a cursor to scroll the list it would be perfect

image
donengel72 commented 1 year ago

I had this issue as well, when using it on multiple monitors. If I open it on my lower monitor, I have this issue, but it doesn’t happen on the top monitor.

NeedsMoar commented 1 year ago

I'm running multiple monitors but one of them is in the "for special applications only" or whatever mode of Windows 10 so it's not a monitor thing. I'm running one of those LG displays with a non-idiotic aspect ratio so it's 2560x2880 in portrait mode. This doesn't happen every time I open a list though, it's kinda random. Normally I'd be able to rapidly hit the top with pageup or home but these don't work.

At this point I have so many random LoRAs laying around I'm thinking either manual categorization by subfolder or automatic by first letter would be useful. Probably manual so you can categorize to your liking, split SDXL stuff into its own directories, etc... It'll already show subdirectories in the name in the list if you have files organized into them so making those into separate pop out menus instead of listing all seems like it would be reasonably easy to at least implement as an option.

vararth commented 1 year ago

This is definitely a much needed feature!

Apacchi88 commented 1 year ago

This was irritating me to no end, until I found a solution that works for me, hopefully it works for you guys too.

Basically I convert the list widget of whatever it is to an input, I then create a primitive node and connect it. Now it will most of the time be at the top of the list with the search bar visible.

donengel72 commented 1 year ago

Wonderful! Will try this. It's a big problem with the artist styler.

On Sun, Oct 29, 2023 at 5:36 AM Apacchi88 @.***> wrote:

This was irritating me to no end, until I found a solution that works for me, hopefully it works for you guys too.

Basically I convert the list widget of whatever it is to an input, I then create a primitive node and connect it. Now it will always be at the top of the list with the search bar visible.

— Reply to this email directly, view it on GitHub https://github.com/comfyanonymous/ComfyUI/issues/1545#issuecomment-1784061065, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMCUPJCO32W67LFRXQAPW3YBYWRLAVCNFSM6AAAAAA43ZU3GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA3DCMBWGU . You are receiving this because you commented.Message ID: @.***>

-- Don Engel

Apacchi88 commented 1 year ago

Wonderful! Will try this. It's a big problem with the artist styler. On Sun, Oct 29, 2023 at 5:36 AM Apacchi88 @.> wrote: This was irritating me to no end, until I found a solution that works for me, hopefully it works for you guys too. Basically I convert the list widget of whatever it is to an input, I then create a primitive node and connect it. Now it will always be at the top of the list with the search bar visible. — Reply to this email directly, view it on GitHub <#1545 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYMCUPJCO32W67LFRXQAPW3YBYWRLAVCNFSM6AAAAAA43ZU3GCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA3DCMBWGU . You are receiving this because you commented.Message ID: @.> -- Don Engel

It works for the most part, sometimes I just have to scroll the view in or out a bit or move the view to the left or right. But the issue happens less with this method.