search

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
52.15k stars 5.49k forks source link

Proper Workflow Management #2906

Open JakeTheSnake3p0 opened 7 months ago

JakeTheSnake3p0 commented 7 months ago

I find it disconcerting how I can't save (overwrite) my current workflow. Currently, I can only download a new file that saves directly to my browser's default downloads directory. If I've opened a workflow, then saving it should simply overwrite it, not prompt a brand new download. If you want to keep it prompting a new download, at least let me specify the location so I can manually choose to overwrite. There should be a default "workflows" directory in the root which should be modifiable through extra_model_paths or some more general config.

ltdrdata commented 7 months ago

Take a look at this: https://github.com/11cafe/comfyui-workspace-manager

Chalice commented 7 months ago

That very much sounds like a problem with your browser settings, and not a problem with ComfyUI. When I hit 'save', I get to choose my save location - including the option to overwrite my old workflow version. Set your browser not to automatically save, but instead let you pick the location.

jn-jairo commented 7 months ago

If I've opened a workflow, then saving it should simply overwrite it, not prompt a brand new download

The "Save" button is a "Download" button, it is supposed to download the workflow, the current workflow is saved automatically in the browser's local storage. So, when you open a workflow using the "Load" button or by dragging it, it will be saved as your current workflow, you don't need to click on "Save" unless you want to download it.

About downloading without asking the path, it is a browser configuration.

Now talking to everyone, it looks like people have a hard time understanding it is a server/client application, they expect the browser to do everything a desktop app can do, but the browser is just a client with a lot of limitations, when you run comfyui in your computer it is the same thing as if comfyui were a web site on some company server, but because they start comfyui in their computer they believe it is just like the other desktop apps they use, a lot of "issues" are just people that doesn't get it.

I don't have a solution for it, but an option to make it work more like a desktop app with a single user could help, and the web interface acting like the ui of that desktop app, so things like saving/loading workflows would work through the websocket, saving in the backend and not in the frontend, and that really feels more natural, because even the input folder is already a folder in the server side, just the workflow doesn't have a management on the server side, as far as I know.