comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
51.24k stars 5.39k forks source link

[BUG] - Major issue post update this week {} Text stings don't work at all #3302

Open RamonGuthrie opened 5 months ago

RamonGuthrie commented 5 months ago

Prior to a recent update, I experienced a frustrating issue where the text cursor would forcefully move to the end whenever I used curly brackets ({}). As reported here: https://github.com/comfyanonymous/ComfyUI/issues/3073 text strings were still rendered correctly at that time. Screenshot 2024-04-19 153307_edit Screenshot 1 (Pre-update issue)

However, after this week's update, text strings enclosed in curly brackets ({}) no longer work at all. Additionally, I encounter this new problem that disrupts my output text and images. (See attached screenshots) Screenshot 2024-04-19 155457_edit Screenshot 2 (Post-update issue)

I've tried everything, including reinstalling ComfyUI, but the problem persists. Can anyone help or suggest a workaround?

ltdrdata commented 5 months ago

In the multiline text widget, the dynamicPrompts used to be set to true by default, but due to persistent issues, it has been changed to false. The creator of the node must change the setting for it to function as it did previously.

RamonGuthrie commented 5 months ago

In the multiline text widget, the dynamicPrompts used to be set to true by default, but due to persistent issues, it has been changed to false. The creator of the node must change the setting for it to function as it did previously.

Thanks for the reply! As a workaround, are there any built-in nodes, or nodes from your ComfyUI-Impact-Pack or ComfyUI-Inspire-Pack, that you could suggest as good replacements?

fabvlator commented 4 months ago

Also reported in WAS Node #383

Was Node Suite > also has Text Multiline with dynamicprompts set to False.

_About this kind of issues, and just trying to bring something positive to the community , I Hope._

I saw this answer a long time ago, now it has a month.

In the multiline text widget, the dynamicPrompts used to be set to true by default, but due to persistent issues, it has been changed to false. The creator of the node must change the setting for it to function as it did previously.

When i saw it I started to find the origin of the issue, then I believe that it started with this [commit 58812ab Don't make dynamicPrompts the default on multiline string inputs.],

What I understand is that the commit changed dynamicPrompts to True in all cases, I tested a vanilla install of Comfy and dynamicPrompts worked just fine with basic CLIP texts. image

Then I have to research all my custom nodes until I found that the Text Multiline node in the WAS Suite been set as "dynamicPrompts": False. I'm not sure if this was a recent change or if it was already set to False previously. Some other users found the same situations with other nodes or extensions. Regardless, this isn't the first time a small change has had a significant impact on everyone's workflows.

We understand that maintainers are doing a great job managing the project, and they likely have a lot on their plates, including other jobs and responsibilities. It's understandable that they might not be able to keep track of every small change or update that could potentially affect users' workflows.

Users and contributors rely on these updates and pull changes, but seldom people will know exactly what has been modified. This can sometimes lead to unexpected issues or disruptions in our workflows. I saw a few of these "update issues" answered in the last couple of days by main contributors, which accounts for not so few time and resources from both users and contributors.

To address this, I kindly request the maintainers and other experts to consider providing some sort of warning, release notes, or details when updates/commits are made. This could be in the form of a small pop-up box, after or before the update process that outlines the changes or provides a list of commits and their descriptions.

We all understand that the software is in a "alpha status", is a work in progress, but exactly for that reason communication is vital for everyone involved. I truly believe it could benefit in decreasing the amount of "issues" and help requests, with the time and resources lost in solving those situations..

Having this information readily available would empower users, including expert users and extension contributors, to make informed decisions and take appropriate actions before updating. It would also make it easier to roll back changes if needed, as users would have the commit information readily available at the time of the update. Which will eventually benefit everyone, and allow a more effective management of such issues.

We understand that adding this level of detail might require additional effort, but it would greatly improve the user experience and reduce potential issues caused by unexpected changes.

Thank you for considering the request, which should probably go somewhere else, but I took the opportunity here.