comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
51k stars 5.35k forks source link

[Question] Best way to share custom Nodes? #334

Open EllangoK opened 1 year ago

EllangoK commented 1 year ago

Hi, I have been working on a couple post processing nodes that can add like additional affects, as it just makes the whole workflow much as easier I won't need to import into like Krita or wherever,

image

I was just wondering, should I create a PR to add these to the repo? I have them in my custom_nodes folder and I can create my own git repo to share them, but like there is no node downloader system yet so I think user's won't be aware of it and they would just manually need to download and copy them.

Just curious about any thoughts you have on this.

For anyone interested in my nodes, simply download post_processing_nodes.py from EllangoK/ComfyUI-post-processing-nodes

comfyanonymous commented 1 year ago

If they work properly and don't add dependencies to the repo I don't mind adding some.

If you make a pull request they should be put in the comfy_extras folder and loaded like I load the nodes_upscale_model.py: https://github.com/comfyanonymous/ComfyUI/blob/master/nodes.py#L1055

EllangoK commented 1 year ago

Sounds good, I'll mostly stick to more basic nodes like blurring and sharpen, or like color and tone correction as I think that will be pretty common use cases and what I often use adobe quickly for.

Thanks for all your work so far!

GaidamakUA commented 1 year ago

I like browsing https://civitai.com/?query=comfyui That's a good way to share and not pollute base nodes.

EllangoK commented 1 year ago

@GaidamakUA Thanks for letting me know about that, I didn't know about that before. WAS Suite seems pretty nice. I do think there should be like an extension system so it is more easily available for users.

However, I do think some nodes should by default in ComfyUI. For example the blend node, almost every package has their own blend node, as it is just a simple operation. Imo i think ComfyUI should implement simple operations as otherwise everyone who makes components will make a duplicate component because they need an essential functionality like blending.