comfyanonymous / ComfyUI

The most powerful and modular stable diffusion GUI, api and backend with a graph/nodes interface.
GNU General Public License v3.0
40.49k stars 4.31k forks source link

[Feature] Support for SD3 ControlNet #3734

Closed Fannovel16 closed 6 hours ago

Fannovel16 commented 1 week ago

Chads from InstantX (who created InstantID) has made several ControlNet for SD3-Medium, including:

Their implementation can be found at https://github.com/huggingface/diffusers/pull/8566

kadirnar commented 1 week ago

+1

sanjay-uzu commented 1 week ago

But these models are not working in comfyui

Fannovel16 commented 1 week ago

@sanjay-uzu That is why we need an issue

zsxkib commented 1 week ago

"Chads from InstantX" lol @Fannovel16

geroldmeisinger commented 1 week ago

controlnet support merged into diffusers https://github.com/huggingface/diffusers/pull/8566#event-13208383785

geroldmeisinger commented 1 week ago

state of the model seems subpar atm https://huggingface.co/InstantX/SD3-Controlnet-Canny/discussions/4 but I guess a 1.0 version will follow soon anyone had better results yet?

kijai commented 4 days ago

state of the model seems subpar atm https://huggingface.co/InstantX/SD3-Controlnet-Canny/discussions/4 but I guess a 1.0 version will follow soon anyone had better results yet?

Here's some of my tests, post and tile work pretty good. This is using diffusers with a wrapper node I made to test this, I added some of the standard CN features that was missing (start/end, guess_mode). Canny seems to work better with more defined input, I found using lineart preproc better. I do definitely think it's worth implementing!

sd3_canny_lines sd3_pose_02 sd3_tilecn sd3_pose_gorilla sd3_pose_cn

sd3_pose_tile_cn_02

al-swaiti commented 3 days ago

its here but in diffusers mode https://github.com/ZHO-ZHO-ZHO/ComfyUI-SD3-Medium-CN-Diffusers waiting for normal one

mcmonkey4eva commented 6 hours ago

Added to Comfy yesterday https://github.com/comfyanonymous/ComfyUI/commit/264caca20e1e051f3bcbec59d7209513ea99d4ed use ControlNetApplySD3 node