The [ SetUnionControlNetType ] options don't mach Flux ControlNet Union modes

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.

https://www.comfy.org/

GNU General Public License v3.0

55.81k stars 5.89k forks source link

Open JorgeR81 opened 2 months ago

JorgeR81 commented 2 months ago

This model supports 7 control modes, including canny (0), tile (1), depth (2), blur (3), pose (4), gray (5), low quality (6).

This was implemented first in a custom node ( now deprecated ). https://github.com/EeroHeikkinen/ComfyUI-eesahesNodes/issues

It seems the order of the options is correct, but they are not properly labeled.

Vigilence commented 1 month ago

@comfyanonymous You forgot the noise option.

JorgeR81 commented 1 month ago

@comfyanonymous You forgot the noise option.

That may be the "_lowquality" option, because they don't have a picture for that.

They probably changed their mind on how to name this option, hence the incorrect naming, in that section.

But the "_lowquality" name, just by itself, can also be confusing for the user.

I think it could be better to have something like "_low_quality / noise / grain_" in the dropdown list, for Comfy UI.

Vigilence commented 1 month ago

I asked on their huggingface page for clarification just to be sure.

simmmis commented 1 month ago

"For a readymade complete workflow (if a bit messy), you can download my updated workflow from here: https://civitai.com/models/709352"

it works!

JorgeR81 commented 1 month ago

A new SetShakkerLabsUnionControlNetType node was added to the ComfyUI-KJNodes, a few days ago: