search

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
56.43k stars 5.98k forks source link

spandrel python package pulls nvidia dependencies even on AMD systems, and since it's in requirements.txt it gets auto installed during updates #4878

Open ikcikoR opened 2 months ago

ikcikoR commented 2 months ago

Expected Behavior

Updating ComfyUI does not install nvidia dependencies on AMD systems

Actual Behavior

Updating ComfyUI installs nvidia dependencies on AMD systems

Steps to Reproduce

source venv/bin/activate pip install -r requirements.txt

Debug Logs

Don't have them anymore and I don't want to install those deps again but out of other things: 

nccl-cu12 nvidia-cuda-cupti-cu12 nvidia-cuda-nvrtc-cu12 nvidia-cuda-runtime-cu12 nvidia-cudnn-cu12 nvidia-cufft-cu12 nvidia-curand-cu12 nvidia-cusolver-cu12 nvidia-cusparse-cu12 nvidia-nccl-cu12 nvidia-nvjitlink-cu12 nvidia-nvtx-cu12

get installed

Other

I suggest not putting spandrel as a default dependency until it doesn't pull nvidia deps on all platforms

ltdrdata commented 2 months ago

Are there any nvidia dependencies that are installed with those dependencies causing problems in your system?

It seems more appropriate to inquire about this issue directly to the spandrel repo. https://github.com/chaiNNer-org/spandrel/issues