search

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
52.03k stars 5.47k forks source link

Node execution cache is broken #4914

Closed ashllay closed 1 week ago

ashllay commented 2 weeks ago

Expected Behavior

On a multi step workflow its spected only the enabled nodes to run but after the commit f6b7194f64ab4b32018eea0da9d9d89a30b582aa it will re-execute all the previous group nodes.

Actual Behavior

re-execute all the previous group nodes.

Steps to Reproduce

Use "fast groups bypasser (rgthree)" to enable at each step. Run 01 - First Step. Enable and run Cnet and Resample. Enable and run 04 Face Detailer, at this point "First Step" will run again, consequently "Cnet and Resample" and then "Face Detailer". SDXL_workflow_example.json

Debug Logs

no errors.

Other

This issue does not happen on 7c6eb4fb29c2c3b4f12605003ab1b7c612d4b4e1 and previous commits.

JettHu commented 2 weeks ago

I found the problem and will submit a PR for another optimization method later.

ashllay commented 1 week ago

fixed on 5e68a4ce67450dd8d3aa1c51c6d06014ac46c03f