search

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
56.57k stars 6k forks source link

Resize Group BUG #5295

Closed OneMonkeyArmy closed 3 weeks ago

OneMonkeyArmy commented 3 weeks ago

Expected Behavior

When resizing any group by clicking and holding the bottom right of it. User should not be able to move the bottom right point above or left of the top left point !!

Actual Behavior

Because the new highlighted area of this inverted group with title at bottom and adjustment triangle at the top, is no longer adjustable, or also it can't be deleted...

unless User manually edit the workflow json file

Steps to Reproduce

Reproduce is explain in the first line...

repair: I didn't took the time to check if the groups are delimited by (x1,y1) + (x2,y2) or (x , y)+width and height.. but it is the same solutions...

Sol 1: add a minimum size in x an y of the GROUP area.

Either prevent the user to move the resize corner above or left of the top left corner, or let user do it but on MOUSE RELEASE, swap the values or make validations/corrections on them.

Debug Logs

WORKAROUND FOR USERS: find the ENTRY in the JSON file ( workflow ) and remove or correct it...

Other

An image worth a 1000 words ! image

LukeG89 commented 3 weeks ago

You should move this issue to the frontend repo: https://github.com/Comfy-Org/ComfyUI_frontend

OneMonkeyArmy commented 3 weeks ago

Do I have to do it manually? Piece by piece?

LukeG89 commented 3 weeks ago

Do I have to do it manually? Piece by piece?

Unfortunately yes.

OneMonkeyArmy commented 3 weeks ago

then just make a link to here...

LukeG89 commented 3 weeks ago

@OneMonkeyArmy I just opened a bug report for you there: https://github.com/Comfy-Org/litegraph.js/issues/216

You can close this one.