search

comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
57.49k stars 6.09k forks source link

[Developer Experience] Add node typing #5676

Open huchenlei opened 2 days ago

huchenlei commented 2 days ago

Upstreams https://github.com/webfiltered/comfy_typing

This PR adds typing support for ComfyUI nodes so that node developers can have type hints from the IDE.

Some other side effects:

comfyanonymous commented 2 days ago

Test is failing, should we drop support for python 3.8 or will you fix it?

huchenlei commented 2 days ago

Test is failing, should we drop support for python 3.8 or will you fix it?

Fixed

huchenlei commented 17 hours ago

@comfyanonymous Ping on review.