comfyanonymous / ComfyUI

The most powerful and modular diffusion model GUI, api and backend with a graph/nodes interface.
https://www.comfy.org/
GNU General Public License v3.0
53.69k stars 5.7k forks source link

please fix the dragging behavior #960

Closed mattymatty closed 3 months ago

mattymatty commented 1 year ago

Please match every other software out there to pan the canvas. Hold spacebar, cursor turns into the hand icon, then click and drag to pan canvas, when done panning release spacebar. There is no need to make a new pattern, it is a very bad user experience for such a common user interaction. It is always recommended to not stray from existing patterns.

NeedsMoar commented 1 year ago

Actually I've never seen spacebar used for that purpose. Most software uses shift since it isn't expected to do anything by default. Spacebar would enter a space if a text element was selected which causes a conflict.

mattymatty commented 1 year ago

Look at every single Adobe, Affinity, Blender, Sketch, Figma product. They all use space at.

Lex-DRL commented 1 year ago

As an experienced Photoshop, Maya, Houdini, Unity, and Nuke user (and the one who's also well-familiar with a ton of secondary software, like Zbrush, Substance, UVLayout, AE, Audition, etc.), here's what I have to say:

So yes, we should use some function key instead, but alt itself seems as a bad choice.

My proposal: adopt Nuke's navigation scheme. After all, it's a 2d editor, not 3d (kinda). But also, it's a purely node-based one (not nodes PLUS SOMETHING) and it's somewhat compatible with patterns in 3d software. I.e:

"or" here means that I suggest both to be working at the same time, not exclusively one or the other. This control scheme is also completely compatible with selection (which, imo, also requires significant rework).

vulpescodex commented 1 year ago

I vote for middle mouse button panning, I have been able to use it in most of the software I use and the habit is difficult to break. And the mouse wheel for zoom seems natural for me.

I would additionally like to request that the default panning and zooming behavior of the browser would be allowed. Half of the time I'm using a MacBook Pro with a trackpad and Safari and currently the trackpad two finger panning gesture zooms the workspace. The speed is also quite rapid creating a jarring experience as most other software I use respects that panning method.

LeeLorenzSr commented 1 year ago

Zoom doesn't work at all for me with my scroll wheel, and from other comments I've seen I'm not the only one. One click of my scroll wheel zooms out to gigantic (beyond scope of window) or in microscopic size. Until I can figure out the simplest navigation issue on ComfyUI, it is unusable.

Lex-DRL commented 1 year ago

Panning with mouse is also mentioned in:

103 , #757 , #624 , #414

subtleGradient commented 10 months ago

This may be relevant: https://github.com/subtleGradient/TinkerBot-tech-for-ComfyUI-Touchpad

amansharma007 commented 9 months ago

This may be relevant: https://github.com/subtleGradient/TinkerBot-tech-for-ComfyUI-Touchpad

Brrooooo. You just saved the whole group! Amazing solution!

robinjhuang commented 3 months ago

Consolidating mouse / dragging feature requests here: https://github.com/comfyanonymous/ComfyUI/issues/624