comfyanonymous / ComfyUI_bitsandbytes_NF4

GNU Affero General Public License v3.0
332 stars 28 forks source link

Node not appearing #3

Open ASilver opened 3 months ago

ASilver commented 3 months ago

I did a standard Git clone into the Custom Nodes, and have the BnB requirement installed, but the new node does not appear anywhere. Even a search for 'NF4' turns up nothing. ComfyUI is updated already. What am I doing wrong? I tried a completely fresh ComfyUI install, updated also, and same issue.

Sefrautic commented 3 months ago

I did a standard Git clone into the Custom Nodes, and have the BnB requirement installed, but the new node does not appear anywhere. Even a search for 'NF4' turns up nothing. ComfyUI is updated already. What am I doing wrong? I tried a completely fresh ComfyUI install, updated also, and same issue.

Same

icey-cold commented 3 months ago

Update your comfyui and make sure the prereqs are installed. This worked fine for me on the first attempt.

My one problem was i was on the flux controlnet branch to begin with, but i swapped back to master before starting. Investigate your environments. Something is wrong on your local machines.

ivanoff13 commented 3 months ago

the prereqs are installed

how can I check it?

ASilver commented 3 months ago

A Discord user clued me in on the problem and solution. If you install bitsandbytes but are using the Portable build, the bitsandbytes package will not be recognized and therefore neither will the node. To fix this, open the Update file

update_comfyui_and_python_dependencies.bat

and add the following line to it:

..\python_embeded\python.exe -s -m pip install -U bitsandbytes

Save it and then run it and it will install the dependency for the embedded Python.

Sup-Shero commented 3 months ago

how to install requirements please i'm a noob I have this error 0.0 seconds (IMPORT FAILED): F:\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_bitsandbytes_NF4

icey-cold commented 3 months ago

A Discord user clued me in on the problem and solution. If you install bitsandbytes but are using the Portable build, the bitsandbytes package will not be recognized and therefore neither will the node. To fix this, open the Update file

This is expected behaviour from python environments. They're meant to be independent of each other so that dependencies don't conflict.

and add the following line to it:

..\python_embeded\python.exe -s -m pip install -U bitsandbytes

Save it and then run it and it will install the dependency for the embedded Python.

You can just run that command in the terminal directly from your root comfyui folder without editing the update bat file and breaking it's purpose.

14422 commented 3 months ago

Didn't seem to work for me. I'm on Windows with the portable ComfyUI.

Tried running that BnB installation manually: D:\ComfyUI\ComfyUI_windows_portable\python_embeded> python.exe -s -m pip install -U bitsandbytes Requirement already satisfied: bitsandbytes in c:\users\***\appdata\local\programs\python\python311\lib\site-packages (0.43.3)

But when I start ComfyUI I get this: Traceback (most recent call last): File "D:\ComfyUI\ComfyUI_windows_portable\ComfyUI\nodes.py", line 1941, in load_custom_node module_spec.loader.exec_module(module) File "<frozen importlib._bootstrap_external>", line 940, in exec_module File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed File "D:\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_bitsandbytes_NF4\__init__.py", line 6, in <module> import bitsandbytes ModuleNotFoundError: No module named 'bitsandbytes'

So no I cannot find the CheckpointLoaderNF4 node nor can I get it installed with the "Install missing nodes" option.

Edit: Oh and also the requirement installation goes through concerning BnB: D:\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_bitsandbytes_NF4> pip install -r .\requirements.txt Requirement already satisfied: bitsandbytes>=0.43.0 in c:\users\***\appdata\local\programs\python\python311\lib\site-packages (from -r .\requirements.txt (line 1)) (0.43.3)

kayselmecnun commented 3 months ago

Same here and not even using the portable version. Updated comfy, BnB was already installed but tried to pip install bitsandbytesto be sure.

Edit: For the people like me who didn't notice this repo is a custom node and not a native comfy UI node, please install it via custom nodes manager lmao

comfyanonymous commented 3 months ago

Node is now in the manager so if you have issues try installing it from there.

bejaranoo commented 3 months ago

Node is now in the manager so if you have issues try installing it from there.

thank you!

14422 commented 3 months ago

Should it be found as Bitsandbytes NF4 from the manager?? Can't find anything starting as Bits from mine. Updated everything and even reinstalled the whole ComfyUI-Manager but still can't find it.

MrUSBEN commented 3 months ago

Should it be found as Bitsandbytes NF4 from the manager?? Can't find anything starting as Bits from mine. Updated everything and even reinstalled the whole ComfyUI-Manager but still can't find it.

Same

bejaranoo commented 3 months ago

Should it be found as Bitsandbytes NF4 from the manager?? Can't find anything starting as Bits from mine. Updated everything and even reinstalled the whole ComfyUI-Manager but still can't find it.

same

boricuapab commented 3 months ago

I hear it's in the dev option in the comfy manager, but I also show another method of doing it here

https://www.youtube.com/watch?v=NkKyu181d_U

There's many solutions to the same problem, hope it helps.

14422 commented 3 months ago

https://www.youtube.com/watch?v=NkKyu181d_U

There's many solutions to the same problem, hope it helps.

Thanks mate!

This one worked for me: ..\..\python_embeded\python.exe -s -m pip install -r "D:\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_bitsandbytes_NF4\requirements.txt"

2PeteShakur commented 3 months ago

https://www.youtube.com/watch?v=NkKyu181d_U There's many solutions to the same problem, hope it helps.

Thanks mate!

This one worked for me: ..\..\python_embeded\python.exe -s -m pip install -r "D:\ComfyUI\ComfyUI_windows_portable\ComfyUI\custom_nodes\ComfyUI_bitsandbytes_NF4\requirements.txt"

yes this command worked for me too now [portable comfy], the node appears! - just change the path in the command to your own comfyui installed nodes path/dir etc :)

polu101 commented 3 months ago

..\python_embeded\python.exe -s -m pip install -U bitsandbytes

its worked.. thank you

tchesket commented 3 months ago

This isn't working for me. I installed bitsandbytes fine, but I am getting an import triton error when I try to run comfyui. I'm not understanding how any Windows users are getting this to work if it relies on triton? Can somebody help?

tchesket commented 3 months ago

This isn't working for me. I installed bitsandbytes fine, but I am getting an import triton error when I try to run comfyui. I'm not understanding how any Windows users are getting this to work if it relies on triton? Can somebody help?

Ok I got it working, I had to literally comment out all of the triton related stuff in the bitsandbytes init.py file. But seems to work like that. Still curious why it was doing that

Brostopher commented 3 months ago

Had the same issue with the node but following the YouTube @boricuapab worked. Thank you

ye-pei-sheng commented 3 months ago

I finded it! 1

XyW-Max commented 3 months ago

A Discord user clued me in on the problem and solution. If you install bitsandbytes but are using the Portable build, the bitsandbytes package will not be recognized and therefore neither will the node. To fix this, open the Update file

This is expected behaviour from python environments. They're meant to be independent of each other so that dependencies don't conflict.

and add the following line to it: ..\python_embeded\python.exe -s -m pip install -U bitsandbytes Save it and then run it and it will install the dependency for the embedded Python.

You can just run that command in the terminal directly from your root comfyui folder without editing the update bat file and breaking it's purpose.

did it & works,

nickapr77 commented 3 months ago

A Discord user clued me in on the problem and solution. If you install bitsandbytes but are using the Portable build, the bitsandbytes package will not be recognized and therefore neither will the node. To fix this, open the Update file

update_comfyui_and_python_dependencies.bat

and add the following line to it:

..\python_embeded\python.exe -s -m pip install -U bitsandbytes

Save it and then run it and it will install the dependency for the embedded Python.

This worked for me, thanks.

Void2258 commented 2 months ago

Node is now in the manager so if you have issues try installing it from there.

It's not found in the manager browser and if I try to install it from URL it says not allowed.