search

comic / evalutils

evalutils helps users create extensions for grand-challenge.org
https://grand-challenge.org
MIT License
23 stars 9 forks source link

fix mypy errors edt32 #301 #304

Closed silvandeleemput closed 3 years ago

silvandeleemput commented 3 years ago

Closes #301

This PR implements the mypy error fix for the improve-stats-typing branch and PR #299

Note: I did change the sampling array internally, to fix several MyPy issues, but this should not be a problem for the functioning of the method. I.e. the sampling array should not be changed outside the scope of the function as a side-effect.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (improve-stats-typing@089498a). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##             improve-stats-typing     #304   +/-   ##
=======================================================
  Coverage                        ?   85.08%           
=======================================================
  Files                           ?       13           
  Lines                           ?      885           
  Branches                        ?      127           
=======================================================
  Hits                            ?      753           
  Misses                          ?       88           
  Partials                        ?       44

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 089498a...78add14. Read the comment docs.

silvandeleemput commented 3 years ago

After discussing with James we are not going forward anymore with typing the edt32 method, we'll leave it untyped since it is not exposed at the API front-end.