Closed silvandeleemput closed 3 years ago
Merging #308 (b7272e7) into master (82f3182) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #308 +/- ##
=======================================
Coverage 85.24% 85.24%
=======================================
Files 13 13
Lines 881 881
Branches 127 127
=======================================
Hits 751 751
Misses 87 87
Partials 43 43
Impacted Files | Coverage Δ | |
---|---|---|
evalutils/stats.py | 86.30% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 82f3182...b7272e7. Read the comment docs.
Closes #302
This PR essentially replaces one line in the edt32 method in stats.py:
with:
They essentially perform the same operation, but the latter is approximately 3x as fast. See also #302 for proof and benchmark. Also, the following nbytes check has the same number of bytes for
dtype=np.int8
anddtype=np.bool
, keeping the behavior for the rest of the method the same.