search

comic / evalutils

evalutils helps users create extensions for grand-challenge.org
https://grand-challenge.org
MIT License
23 stars 9 forks source link

provide named parameters for intrange to make compatible with latest version of click #313

Closed silvandeleemput closed 3 years ago

silvandeleemput commented 3 years ago

Closes #312

Added named parameters to the IntRange object to avoid issues with newer versions of click. See #312 for a detailed description of the issue. This should fix our CI tests.

codecov[bot] commented 3 years ago

Codecov Report

Merging #313 (1ab2b74) into master (dbfabbd) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   85.24%   85.24%           
=======================================
  Files          13       13           
  Lines         881      881           
  Branches      127      127           
=======================================
  Hits          751      751           
  Misses         87       87           
  Partials       43       43
Impacted Files Coverage Δ
evalutils/cli.py 71.56% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dbfabbd...1ab2b74. Read the comment docs.

jmsmkn commented 3 years ago

Can you also update setup.py to update which version of click we require now (click>=8?)

silvandeleemput commented 3 years ago

The fix works for all versions of click, so no need to fix the version.