search

comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging
https://grand-challenge.org
Apache License 2.0
168 stars 50 forks source link

Simplify json error reporting #3286

Closed amickan closed 3 months ago

amickan commented 3 months ago

Json validation errors used to include the instance (the submitted json), the schema and the error. This changes the reporting to only print the error message without the schema and instance. This is a temporary fix until this is implemented: https://github.com/python-jsonschema/jsonschema/issues/1218

It also standardizes the message for FILE_COPY_STATUS notifications, opting for the less verbose version.

amickan commented 3 months ago

Some of the tests that involve checking the returned json validation error currently don't pass. I wanted to get feedback on the general approach first before I change the tests. Maybe we decide not to change anything and wait for the feature request to be implemented.

jmsmkn commented 3 months ago

Yes the approach is fine for now. Would be happy for you to work on fixing this upstream if you can.

amickan commented 3 months ago

Would be happy for you to work on fixing this upstream if you can.

I think I will wait this one out a little longer. From the conversation on the issue it sounds like the person who proposed it has a pretty clear idea of how to implement it already (whereas I don't, yet) and I have other things higher up on my priority list at the moment. I might give it a shot later though, if it hasn't been tackled by then.