comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging
https://grand-challenge.org
Apache License 2.0
175 stars 50 forks source link

Mismatch in evaluation jobs when challenge admin pre-runs algorithm on cases from the phases archive #3302

Closed jmsmkn closed 2 months ago

jmsmkn commented 5 months ago

create_algorithm_jobs_for_evaluation exits successfully but the evaluation remains in the executing algorithm state. Occurs when the challenge admin uses the try out algorithm page and selects an image from the archive linked to the phase. Probably the jobs need filtering by creator?

amickan commented 5 months ago

I remember that we had this issue once before. I would have thought that we fixed it then... but I guess not. I will see if I can find our conversation back tomorrow.

amickan commented 5 months ago

Can't find anything... only that we used to filter by creator, but removed that here: https://github.com/comic/grand-challenge.org/commit/10fa528855b986914a76e0071b637c9780852a6e#diff-3de0492fca47670a7223a3218b626d8a5ae21bddebf88c6fc58499e64447eecd I think we just need to add that filter back.

amickan commented 4 months ago

I think this happened again for submission e4d72823-3013-4c5a-a45f-7d848e107554 and evaluation a883a7ff-052d-4593-b348-9cebb512d55e. How do we fix this? Delete the algorithm job?

jmsmkn commented 4 months ago

I think that would work.

amickan commented 4 months ago

I'll create an admin issue for it.

jmsmkn commented 4 months ago

This happened again - is there a reason why we cannot add the filter back?

amickan commented 4 months ago

Not that I know. I don't know why it was removed in the first place.

jmsmkn commented 4 months ago

Me either - I removed it in this commit which was removing batch job creation, unrelated to the evaluation. Think it must have been a mistake.

amickan commented 4 months ago

Let's put it back then. We will find out soon enough if there was a reason, I guess.

amickan commented 4 months ago

I can create a PR

jmsmkn commented 2 months ago

This occurred yet again.