Closed chrisvanrun closed 1 month ago
I would have thought that the template and view would need updating too as the rank will not be present for excluded fields, right?
I would have thought that the template and view would need updating too as the rank will not be present for excluded fields, right?
I might have completely missed the fact that the leaderboard templating changed if the scoring method changed! I'll look into this after the weekend.
Refactor the test(s) and have updated the leaderboard template to not decorate the excluded metrics:
Part of the tiny pitch:
This PR adds an optional (default: false)
exclude_from_ranking
field in the extra results columns JSON definition. Setting it totrue
allows additional metrics to be shown on Challenge leaderboards while being ignored while calculating the rank.The related test is a construction copy of
test_calculate_ranks
since I did not find it wise to extend that test with yet another factor. It would have pushed the 12 (2x3x2) to 24 which is over the top imho.