search

comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging
https://grand-challenge.org
Apache License 2.0
167 stars 49 forks source link

Fix not having Text widget set when creating questions #3353

Closed chrisvanrun closed 1 month ago

chrisvanrun commented 1 month ago

This PR sets the default of the question answer_type to TEXT on the model level. It was already indirectly the default via the form and being the first option. For the widget choices, this was not clear during the initial render so the options were left empty.

The alternative is to fix it on the Form level but it seems better to make it explicit on the model level.

jmsmkn commented 1 month ago

The alternative is to fix it on the Form level but it seems better to make it explicit on the model level.

Actually, I think this is better to fix on the form level as it is a problem with the form. The only change I think that model field should have is blank=False, we want users of the field to be explicit about setting the question type.

chrisvanrun commented 1 month ago

Will implement in a different PR.