comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging
https://grand-challenge.org
Apache License 2.0
167 stars 49 forks source link

Add external evaluators group to challenges #3395

Closed amickan closed 1 week ago

amickan commented 1 week ago

First tiny PR to add the external_evaluators_group to the challenge model. This needs to happen in two steps: first, add the field as nullable and do a data migration to create this group for all existing challenges. That's what this PR does. In the next PR (together with all the other model changes for the pitch), we make the field non-nullable.

Part of https://github.com/DIAGNijmegen/rse-roadmap/issues/310

amickan commented 1 week ago

I'm unsure if the "create groups for existing challenges" migration step should be separated out, i.e. doing this in 3 PRs. If someone creates a challenge while we deploy and run the migrations, that challenge would not get this group since the new code is not live yet and the migration here might not pick it up yet. Then again, noone can just create a challenge, so this is extremely unlikely to happen, so maybe ok in this case?

jmsmkn commented 1 week ago

When migrations are applied I think that the entire table is locked, so that should be a non-issue.