Question choice options do not get stored on initial save

comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging

https://grand-challenge.org

Apache License 2.0

168 stars 50 forks source link

Question choice options do not get stored on initial save #3403

Open jmsmkn opened 5 days ago

jmsmkn commented 5 days ago

To reproduce:

Create a reader study
Add a question, set the type to Choice, Add an option
Click save
Click on edit question, notice that the options are gone. Adding them here works.

jmsmkn commented 3 days ago

I've had a look at this and the implementation of the dynamic choice fields was a mess. Doing all sorts of validation and redirection in form_valid. I've refactored this to do everything in its correct place on the form, and to use standard crispy forms for rendering. Trying to add back the dynamic adjustments was a massive rabbit hole.