Quick preview of Job error messages

comic / grand-challenge.org

A platform for end-to-end development of machine learning solutions in biomedical imaging

https://grand-challenge.org

Apache License 2.0

175 stars 50 forks source link

Quick preview of Job error messages #3417

Closed chrisvanrun closed 3 months ago

chrisvanrun commented 3 months ago

Closes: #3405

https://github.com/comic/grand-challenge.org/assets/7871310/ca188345-4fe4-4290-9ea7-d6f49f7cf14e

jmsmkn commented 3 months ago

What does this look like for algorithms that succeed but have warnings (e.g. output on stderr)?

chrisvanrun commented 3 months ago

Not sure what the interaction is between stderr and error_message. Sometimes one is deduced from the other I think? If that is the case it will show the 'warning' type but include a modal option.

jmsmkn commented 3 months ago

error_message has a bunch of sources but it will not be set if the job is successful. If a job really failed the Results column would be empty. Would it be a good idea to put the error message there rather than "Empty"+modal?

chrisvanrun commented 3 months ago

Mhh. I don't think we should dump the error_message directly in the Results column, but we COULD add a badge + modal construct there which is way more in line with the current UI.

chrisvanrun commented 3 months ago

With the latest commit, show casing a maximum sized error_message (1024 char):

https://github.com/comic/grand-challenge.org/assets/7871310/38e3bfda-544c-4a30-bf4d-c1d5f6d6a796