comictagger / gcd_talker

A Grand Comics Database talker for Comictagger
Apache License 2.0
5 stars 1 forks source link

web link don´t working with comictagger´s multiple web links #12

Closed Vertigooo2 closed 5 months ago

Vertigooo2 commented 7 months ago

After the change in comictagger for multiple links (Support multiple web_links), it is necessary to adapt gcd_talker. I have tested that it works again by making the following changes:

from urllib3.util import parse_url

md.web_link = urljoin(self.website, f"issue/{issue['id']}")

with:

md.web_links = [parse_url(urljoin(self.website, f"issue/{issue['id']}"))]

mizaki commented 7 months ago

10 has the change with an expected new alpha but it might not appear so I'll remove that and push it through because the master "aims" to be up-to-date with CT develop.

mizaki commented 7 months ago

I lied about taking the min version, it should work with master as long as your ctversion.py has been created recently.

mizaki commented 5 months ago

Fixed in #10