Fixes #15, #17, #18, and does other improvements

comigor / fuzzy

Fuzzy search in Dart

MIT License

37 stars 20 forks source link

Fixes #15, #17, #18, and does other improvements #16

Closed luistrivelatto closed 3 years ago

luistrivelatto commented 3 years ago

Added tests reproducing the crash in #15, and fixed by removing empty tokens after tokenizing.

luistrivelatto commented 3 years ago

Added some commits that also fixes #17, #18, and fixes an apparent bug in weighted search.

ghost commented 3 years ago

Thanks @luistrivelatto. I'll use your fork and report back.

comigor commented 3 years ago

Hello @luistrivelatto, thank you so much for this PR (and sorry for the late reply)! I'll fix the pipeline and review it soon!

luistrivelatto commented 3 years ago

Thanks @comigor. Sorry about piling up commits in a single PR, I've changed the title to reflect the changes better.

I'm currently using the lib for tokenized, weighted search, and the results are satisfying. I've gathered 50+ search tests on my data, and only one of them didn't give the expected intuitive results, but I don't consider it a fault of the algorithm because it's due to some use case-specific "gotcha" (a search token ends up being substring of two item tokens, then gives 2 perfect matches when I expected one). I can live with that hehe

Thanks for the package :)

comigor commented 3 years ago

@luistrivelatto No problems! Thanks for stepping up and fix those issues!

Before we merge, could you please update the CHANGELOG with all the changes you did?

luistrivelatto commented 3 years ago

Sure, done.

comigor commented 3 years ago

Thank you very much!

comigor commented 3 years ago

Published as 0.3.0