search

comigor / fuzzy

Fuzzy search in Dart
MIT License
37 stars 20 forks source link

[fix] fix range errors, allow empty pattern, fixes #3, fixes #4 #6

Closed danielmahon closed 4 years ago

danielmahon commented 4 years ago

So, I haven't gone through the codebase enough yet to know if these are the "proper" fixes but I was running into a bunch of errors right off the bat and these seem to fix them, mostly allowing an empty pattern (which just returns the original list), and a couple of other range errors.

Thanks for this by the way! I got really excited when I saw this package as I was converting a React search that already used Fuse.js.

Needed to add the meta dependency for the @required annotation.

Signed-off-by: Daniel Mahon danielmahon@users.noreply.github.com

comigor commented 4 years ago

Hello there @danielmahon,

Thanks for your time opening this PR!

Actually, this whole reimplementation was kinda hacky, and I hope to be able to do it properly in the future. Until then, every fix like this one would be greatly appreciated.