Bitcoin ledger definition should use "magic bytes" to identify the network

[bonomat]

Currently we are using testnet and mainnet when talking about the different networks of Bitcoin. Every message between bitcoin nodes is prefixed with 4 bytes identifying the network the message is for.

We want to use those 4 bytes to identify the network in our swap messages. Hints:

• Think about endianess.
• Think about hex vs dec encoding.

DoD:

• replace testnet with testnet3 magic bytes for bitcoin networks
• replace mainnet with mainnet magic bytes for bitcoin networks

among others, this will need to be updated in the registry

Once this is done:

• create ticket for updating comit-rs (SWAP message + HTTP API)
• create ticket for updating comit-i (HTTP API)

Related: https://github.com/comit-network/comit-rs/pull/1127

[D4nte]

I think testnet and mainnet are valid qualifications for the bitcoin networks. IMHO, the way bitcoind JSON RPC express these networks should not change the way we express them in our SWAP messages.

[D4nte]

After much debate with @thomaseizinger, my current proposal is to hold this back until we know more about client behaviour.

What we really need to do is see how the network parameter is used by the clients.

• If cnd clients commonly use magic number than that is what we should return.
• If clients commonly map from testnet to testnet3 then we should return testnet3.

Hence the first step would be to add network verification for bitcoin on our client and see if we always do the same mapping.