search

comit-network / RFCs

Request for Comments (RFCs) for the COMIT network
9 stars 3 forks source link

Remove ERROR frame from rfc-001 #118

Closed tcharding closed 5 years ago

tcharding commented 5 years ago

Recent work attempting to implement the ERROR frame as described in rcf-001 found that the ERROR frame was not the best solution to the problem it was trying to solve. For now we decided to just close the stream for message level errors. We should update the RFC to mirror what was implemented in comit-rs. Since rcf-001 does not yet mention libp2p; specifically do not mention the word 'stream' instead use 'communication channel'.

Remove ERROR frame from rfc-001. Add description of current error handling behaviour implemented in comit-rs.

Fixes: #117

tcharding commented 5 years ago

ZenHub fail, cannot connect this PR to the issue.