comit-network / ambrosia

UI for trading in the COMIT network
Apache License 2.0
4 stars 3 forks source link

Hooks for balances, orders, book and market #53

Closed da-kami closed 4 years ago

da-kami commented 4 years ago

You had a good point there earlier @thomaseizinger 😁 - pretty sweet composing those hooks

da-kami commented 4 years ago

With the last 4 commits we add proper loading states. Since I did not want to tear down everything I added the loading state to the domain objects (i.e. CurrencyValue, Market). We could opt for keeping this state outside these objects, but for now it was easier to deal with the functionality this way. Tested the behavior in the UI and it is pretty smooth, due to caching it sometimes flickers between minus value and Spinner, but that is acceptable I'd say.