comit-network / ambrosia

UI for trading in the COMIT network
Apache License 2.0
4 stars 3 forks source link

Use all currency logos as Icon instead of Image #59

Closed da-kami closed 4 years ago

da-kami commented 4 years ago

To harmonize the codebase and make it easier to use the logos as icons.

D4nte commented 4 years ago

How can visually check the changes?

da-kami commented 4 years ago

How can visually check the changes?

The only easy way to achieve this would be pasting screenshots I suppose.

Concerning this specific fix there is no visual change, I just use a different component from chakra-ui (Icon instead of Image). Icon is more convenient to use, because I can define SVG icons in the theme.tsx and don't have to bother about import statements for the svg files.