search

comit-network / ambrosia

UI for trading in the COMIT network
Apache License 2.0
4 stars 3 forks source link

Remove unused code and files #9

Closed da-kami closed 4 years ago

da-kami commented 4 years ago

@yosriady is there a problem with CI? Looks like the installs are failing.

image

yosriady commented 4 years ago

@da-kami Yeah, looks like it. Odd, because the last commit only had lint errors https://github.com/comit-network/taker-ui/runs/844127189

I think it might be the ubuntu pipeline? The other pipelines are halted if another has an error. What you're seeing is the macos-latest pipeline being cancelled early because of a failure in ubuntu-latest: https://github.com/comit-network/taker-ui/runs/864205265?check_suite_focus=true

Screenshot 2020-07-13 at 1 35 59 PM

Looks like a Github availability issue to me.

yosriady commented 4 years ago

@da-kami Could you retrigger the pipeline to check if it's a transient fault? Just make another push.

da-kami commented 4 years ago

Puh, after re-trigger I noticed there is quite a lot of yarn tsc errors. Started cleaning up, but decided it might actually be better to wire in the Bitcoin wallet first, otherwise I have to touch some things twice.

Not sure if this PR should get merged. What do you think @yosriady ?

yosriady commented 4 years ago

@da-kami You don't have to fix all the lint errors, just fix the ones you can and I'll fix the rest.

da-kami commented 4 years ago

Closing this in favour of doing doing it together with the Bitcoin wallet PR.