comit-network / app

Moved to
https://github.com/comit-network/taker-ui
MIT License
1 stars 1 forks source link

Refactor retrieving swaps and using swaps as stateful objects #34

Closed yosriady closed 4 years ago

yosriady commented 4 years ago

https://github.com/comit-network/app/blob/feature/state-machines/app/containers/SwapDetailsPage.tsx#L23-L48

Use url instead of id

Swaps are Stateful

yosriady commented 4 years ago

https://github.com/comit-network/comit-js-sdk/blob/d54f3ae793d18e98189c817e568242b0eb7b89e3/src/comit_client.ts#L150-L154

yosriady commented 4 years ago

https://github.com/comit-network/comit-js-sdk/blob/cef77e4f1a54a9291184cd384040a6d3af7fbd58/src/swap.ts#L28-L34

yosriady commented 4 years ago

The app would need to manage a singleton context of a cnd instance, BitcoinWallet, and EthereumWallet to retrieve a swap in the canonical way.

Split into separate parts:

yosriady commented 4 years ago
yosriady commented 4 years ago

EDIT: obsolete with new GET /swaps/:id endpoint https://github.com/comit-network/comit-rs/pull/2521