Closed yosriady closed 4 years ago
The app would need to manage a singleton context of a cnd
instance, BitcoinWallet, and EthereumWallet to retrieve a swap in the canonical way.
isTakerLoading/ed
-> loading/ed
Split into separate parts:
TakerProvider
(Actor context) in favour of individual wallet, cnd, client contextsSwap
is mutable, instead of passing Swap[]
as props into SwapList
, it should be loaded from a global context instead e.g. useSwaps()
/swaps/:id
will then pull data from this global storeEDIT: obsolete with new GET /swaps/:id
endpoint https://github.com/comit-network/comit-rs/pull/2521
https://github.com/comit-network/app/blob/feature/state-machines/app/containers/SwapDetailsPage.tsx#L23-L48
Use url instead of id
self
property on the swap object'Swaps are Stateful
swap
into state.findSwapById
,retrieveSwapById
useInterval
is limited to callingfetchDetails()