search

comit-network / baru

GNU General Public License v3.0
4 stars 4 forks source link

Infer chain based on borrower and lender addresses #44

Closed luckysori closed 3 years ago

luckysori commented 3 years ago

Fixes #28.

luckysori commented 3 years ago

@thomaseizinger: Am I going too far in modelling the chain like this or is it a good idea?

thomaseizinger commented 3 years ago

@thomaseizinger: Am I going too far in modelling the chain like this or is it a good idea?

Seems reasonable to me for now. It is all internal so you can always change it later.

Any alternative I can think of would involve no longer accepting addresses on the API but instead dealing with public keys directly. That would be a much bigger change so I think this is a good step forward. If we hit a limitation here, we need to re-consider passing addresses around.