Upgrade Botimus to handle loan calc and validation

comit-network / waves

Workspace for project waves - bringing DeFi to Liquid.

MIT License

15 stars 6 forks source link

Closed da-kami closed 3 years ago

da-kami commented 3 years ago

Lender now includes the loan calculations and the validation of the loan. I clicked it through and it looks sane :)

To be done in follow ups:

Send all amounts in sats and do conversion on UI side (did not tackle all amounts yet)
Validation step for the loan term
Upgrade the UI so the borrower can select values

bonomat commented 3 years ago

I see one issue (somehow related but not a blocker): in the UI we always show the principal amount instead of the repayment amount. Unfortunately it does not seem to be possible to get hold of this number from what is available in https://github.com/comit-network/waves/blob/06701f852298e28bbba69d5d83ed44e36301775a/extension/wallet/src/wallet/extract_loan.rs#L11