search

comit-network / xmr-btc-swap

Bitcoin–Monero Cross-chain Atomic Swap
GNU General Public License v3.0
658 stars 85 forks source link

Use `libtor` to bundle tor directly into the CLI #1455

Open binarybaron opened 11 months ago

binarybaron commented 11 months ago

We could use this library https://github.com/MagicalBitcoin/libtor to bundle tor

delta1 commented 11 months ago

i have done this before on a different project and it doesn’t build natively on windows. still, we can put it behind a feature flag and use that for linux/macos binaries

delta1 commented 11 months ago

for reference: https://github.com/tari-project/tari/pull/3641#issuecomment-1006557338

binarybaron commented 11 months ago

it doesn’t build natively on windows

that's a bummer :(

binarybaron commented 3 months ago

i have done this before on a different project and it doesn’t build natively on windows. still, we can put it behind a feature flag and use that for linux/macos binaries

But we can build it for windows on linux

delta1 commented 3 months ago

true, it just means devs on windows can’t build without msys2/mingw

sneurlax commented 3 months ago

true, it just means devs on windows can’t build without msys2/mingw

have had to do this often, unfortunate tho it is