search

commIT-Group / card-details-form

https://commit-group.github.io/card-details-form/
3 stars 0 forks source link

HTML bodypage markup #14

Closed car2t closed 1 year ago

car2t commented 1 year ago

Create DIV wrapper for main content and put cards in an aside element, it could be a DIV too I think. Add some SPAN for cards decorations

Add meaning full ID values and some classes attributes as well. ID names are important, classes not that much. I hope did not repeat anything.

Delete some FIELDSET elements since there were not grouping anything. Switch LEGEND elements for LABEL elements too. It needs a FOR attribute too, but later on we can add.

Wrap completed state elements into a DIV. This part is important decide already how we want to do it. Markup can change depending the solution. Switch H1 for a P element, it did not make sense.

The CONFIRM button should be an INPUT element if after submit it goes to other HTML page. It needs some attribute yet thought. Another thing to do.

WitchDevelops commented 1 year ago

Untitled

Why add ID and a class of the same name to so many elements? is there a reason?

car2t commented 1 year ago

Untitled

Why add ID and a class of the same name to so many elements? is there a reason?

Hi Domi

I was just trying to show case the ID names, providing also something to help with the logic after. We should not use them in our CSS.

Classes was more a just in case thing and to give some naming ideas, but most of them probably no necessary and better use for grouping styles and refactor. Probably better markup without classes and do the CSS without them. Refactoring at the end using classes. I did not think in the styles during the markup, so I wasn't thinking in nothing special with those classes.

If you all want I keep going with this markup I can get rid of all classes, and we could add some later on during refactoring process of our CSS.

I also we keep my next pull requests with smaller chunks of code. It will make easier to everyone read and review. And easier to follow the process as well.

Thank you for reading all Domi, this one was a lot!