search

commaai / flash

https://flash.comma.ai
5 stars 17 forks source link

Deployed version of flash.comma.ai still references sendEvent from "`rm analytics`" #27

Closed nelsonjchen closed 11 months ago

nelsonjchen commented 11 months ago

Commit rm analytics: https://github.com/commaai/flash/commit/9b0b00b36705224e737ce9b7e5edf4fdb5b6476d

Console Error:

Screenshot_2023-11-13_at_8 08 54_PM

Minified chunk still has sendEvent:

image

Probably the cause of issues like in #26 . Maybe some top level webpack'd file wasn't deployed correctly.

adeebshihadeh commented 11 months ago

Looks like this was some more sendEvent usage (8d9982cc1bdfe04ffc59dee87fb11fd77f811d79). Deploying an update shortly

nelsonjchen commented 11 months ago

Pending confirmation from people who are looking to use it/need it in the flashing thread,

nelsonjchen commented 11 months ago

https://discord.com/channels/469524606043160576/1138960979384881212/1174375634479357992

image